hi Ben,
On Tue, Oct 26, 2010 at 6:41 PM, Ben Gardiner bengardiner@nanometrics.cawrote:
../sugosh-da8xx-v2/3of3.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS.
I was also unable to build the da850evm u-boot with this patch applied: $make mrproper ; make da850evm_config ; make -j9 all|grep -E '( error| warning)' awk '(NF && $1 !~ /^#/) { print $1 ": " $1 "_config; $(MAKE)" }' boards.cfg > .boards.depend Configuring for da850evm board... davinci_pinmux.c:30:26: error: davinci_misc.h: No such file or directory make[1]: *** No rule to make target `.depend', needed by `libdavinci.a'. Stop. make: *** [board/davinci/common/libdavinci.a] Error 2 make: *** Waiting for unfinished jobs.... make: *** wait: No child processes. Stop.
For your next patch submission, I recommend running checkpatch.pl (from a recent linux kernel scripts/ directory) on your patches and also using the ./MAKEALL script [1] to test that your changes haven't broken other boards.
Thanks a lot for the testing. Will check the patches with checkpatch script while posting the next version.
-sughosh