Re: [PATCH v4 12/13] x86: galileo: Use devicetree for SMBIOS settings

Hi Simon,

On Thu, Oct 22, 2020 at 10:20 PM Simon Glass sjg@chromium.org wrote:

Add settings and enable the default sysinfo driver so that these can come from the device tree.

Signed-off-by: Simon Glass sjg@chromium.org

(no changes since v1)

arch/x86/dts/galileo.dts | 18 ++++++++++++++++++ board/intel/galileo/Kconfig | 11 ----------- 2 files changed, 18 insertions(+), 11 deletions(-)

diff --git a/arch/x86/dts/galileo.dts b/arch/x86/dts/galileo.dts index 5de4568679a..18d6cf625e9 100644 --- a/arch/x86/dts/galileo.dts +++ b/arch/x86/dts/galileo.dts @@ -164,4 +164,22 @@ }; };

•   smbios {
  

•           compatible = "u-boot,sysinfo-smbios";
  

•           smbios {
  

•                   system {
  

•                           product = "GalileoGen2";
  

•                   };
  

•                   baseboard {
  

•                           product = "GalileoGen2";
  

•                   };
  

•                   chassis {
  

•                           product = "GalileoGen2";
  

•                   };
  

•           };
  

•   };
  

}; diff --git a/board/intel/galileo/Kconfig b/board/intel/galileo/Kconfig index 1416c891e86..fb8d94fb5b1 100644 --- a/board/intel/galileo/Kconfig +++ b/board/intel/galileo/Kconfig @@ -22,15 +22,4 @@ config BOARD_SPECIFIC_OPTIONS # dummy select BOARD_ROMSIZE_KB_1024 select SPI_FLASH_WINBOND

-config SMBIOS_PRODUCT_NAME

•   default "GalileoGen2"
  

•   help
  

•     Override the default product name U-Boot reports in the SMBIOS
  

•     table, to be compatible with the Intel provided UEFI BIOS, as
  

•     Linux kernel drivers (drivers/mfd/intel_quark_i2c_gpio.c and
  

•     drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c) make use of
  

•     it to do different board level configuration.
  

•     This can be "Galileo" for GEN1 Galileo board.
  

Please convert the above help messages into a comment block in the smbios {} devicetree block so that we don't lose such information for future reference.

Regards, Bin