On 12/17/19 1:52 PM, Tom Rini wrote:
On Tue, Dec 17, 2019 at 08:38:48AM +0100, Marek Vasut wrote:
On 11/7/19 9:04 PM, Joe Hershberger wrote:
On Thu, Nov 7, 2019 at 1:16 PM Tom Rini trini@konsulko.com wrote:
On Tue, Nov 05, 2019 at 04:05:11AM +0000, Priyanka Jain wrote:
Fix 'mask' calculation in phy_connect() for phy addr '0'. 'mask' is getting set to '0xffffffff' for phy addr '0' in phy_connect() whereas expected value is '0'.
Signed-off-by: Priyanka Jain priyanka.jain@nxp.com
Reported-by: tetsu-aoki via github
Acked-by: Joe Hershberger joe.hershberger@ni.com
Sadly, this breaks systems where a PHY is at address 0. I have such an STM32MP1 system with LAN8720 PHY and since this patch, I cannot use ethernet. Please revert.
Well, a simple revert breaks the other boards that this fixes. So we need to think about how to fix all of the cases involved here, thanks!
That's probably task for the author of the patch.
btw -rc4 worked fine, -rc5 does not work.