Re: [U-Boot] [PATCH 5/8] tegra: usb: move controller init into start_port

Dear Lucas Stach,

There is no need to init a USB controller before the upper layers indicate that they are actually going to use it.

board_usb_init now only parses the device tree and sets up the common pll.

Signed-off-by: Lucas Stach dev@lynxeye.de

arch/arm/cpu/armv7/tegra20/usb.c | 47 +++++++++++++++------------------------- 1 Datei geändert, 18 Zeilen hinzugefügt(+), 29 Zeilen entfernt(-)

diff --git a/arch/arm/cpu/armv7/tegra20/usb.c b/arch/arm/cpu/armv7/tegra20/usb.c index cf800b1..e372b8b 100644 --- a/arch/arm/cpu/armv7/tegra20/usb.c +++ b/arch/arm/cpu/armv7/tegra20/usb.c @@ -417,44 +417,29 @@ static int init_ulpi_usb_controller(struct fdt_usb *config) } #endif

-/**

• • Add a new USB port to the list of available ports.
• • @param config USB port configuration
• • @return 0 if ok, -1 if error (too many ports)
• */

-static int add_port(struct fdt_usb *config)

Fix the comment instead of removing it?

[...]

Best regards, Marek Vasut