In message 20050201125802.28721.qmail@web54405.mail.yahoo.com you wrote:
Here is a cleaner patch incorporating your suggestions.
Ummm... I'm afraid it is not cleaner in any way.
Sorry, but there are so many issues with your patch that I have to reject it. You really have to *check* your patch and inspect what it's doing to the source code.
Here are a few examples:
diff -p -u -r1.165 Makefile --- Makefile 9 Jan 2005 23:48:14 -0000 1.165 +++ Makefile 1 Feb 2005 12:35:26 -0000 @@ -42,10 +42,16 @@ VENDOR=
...
ifeq (include/config.mk,$(wildcard include/config.mk)) # load ARCH, BOARD, and CPU configuration include include/config.mk -export ARCH CPU BOARD VENDOR SOC +export ARCH CPU BOARD VENDOR
Here you kill SOC support.
@@ -64,6 +70,7 @@ ifeq ($(HOSTARCH),i386) CROSS_COMPILE = else CROSS_COMPILE = i386-linux-
endif endif ifeq ($(ARCH),mips) @@ -84,12 +91,14 @@ endif endif endif
+CROSS_COMPILE = sde- export CROSS_COMPILE
Arbitrary white space changes.
######################################################################### # U-Boot objects....order is important (i.e. start must be first)
OBJS = cpu/$(CPU)/start.o
+OBJS = cpu/$(CPU)/start.o
Duplicate entry of "cpu/$(CPU)/start.o"
LIBS += fs/cramfs/libcramfs.a fs/fat/libfat.a fs/fdos/libfdos.a fs/jffs2/libjffs2.a \
- fs/reiserfs/libreiserfs.a fs/ext2/libext2fs.a
- fs/reiserfs/libreiserfs.a
Here you kiss ext2 file system support.
all: $(ALL)
-u-boot.hex: u-boot
$(OBJCOPY) ${OBJCFLAGS} -O ihex $< $@
You remove a build target.
-u-boot: depend $(SUBDIRS) $(OBJS) $(LIBS) $(LDSCRIPT) +u-boot: $(SUBDIRS) $(OBJS) $(LIBS) $(LDSCRIPT)
You kill the build system by not building the dependencies.
etags: etags -a `find $(SUBDIRS) include \
lib_generic board/$(BOARDDIR) cpu/$(CPU) lib_$(ARCH) \fs/cramfs fs/fat fs/fdos fs/jffs2 \net disk rtc dtt drivers drivers/sk98lin common \ \( -name CVS -prune \) -o \( -name '*.[ch]' -print \)`
You killt he etags target.
-incaip_100MHz_config \ -incaip_133MHz_config \ -incaip_150MHz_config \ incaip_config: unconfig
You corrupt the INKAIP board.
- rm -f tools/mpc86x_clk tools/ncb
- rm -f tools/mpc86x_clk
You leave garbage hanging around.
And so on.
Sorry, but this is simply not acceptable. Please clean up (and I really mean: clean up) and resubmit.
Best regards,
Wolfgang Denk