On 03/04/2013 18:54, Dirk Behme wrote:
Am 03.04.2013 11:12, schrieb Stefano Babic:
On 21/03/2013 09:03, Dirk Behme wrote:
Reviewing the ECSPI reset handling shows two issues:
Hi Dirk,
agree completely, only a very minor question..
- reg_ctrl = reg_read(®s->ctrl);
As you says, it makes no sense to read back the value of the register, also because reg_ctrl is overwritten some lines later ;-)
Hmm, sorry if I overlooked something, but we have to initialize the variable 'reg_ctrl' with the recent register content because it is first used and _then_ overwritten in the next step:
reg_ctrl = (reg_ctrl & ~MXC_CSPICTRL_SELCHAN(3)) | MXC_CSPICTRL_SELCHAN(cs);
What I meant is that we know already the value of the register. Your patch set it to MXC_CSPICTRL_EN, and this could be put in or later when you set again the register ;-)
Nevermind, your patch is ok and fixes a real problem. What I commented are more or less style-related.
I merge it and push for the release.
Best regards, Stefano