-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 09/17/12 10:54, Ilya Yanok wrote:
Hi Tom,
On Mon, Sep 17, 2012 at 9:04 PM, Tom Rini <trini@ti.com mailto:trini@ti.com> wrote:
I agree it's not the best place... config_cmd_spl.h sounds a little bit crazy as we don't have any commands at all in SPL...
How about config_uncmd_spl.h then and a nice big comment up top
Well, it will be at least less confusing...
explaining what we're doing. Or can we take another stab at seeing why some stuff isn't being garbage collected? If garbage_collected_func_a calls never_seen_while_linking_func, we still succeed since we garbage collect the first func. There's just the gcc issue I've noted before about strings.
That's not really about garbage collection in this case (net-spl). I want to disable some functionality of generic net code not some stuff used only by commands implementation. The confusion comes from the fact that this code is protected by CONFIG_CMD_* defines.
So I guess the code construct is roughly: function_we_need(...) { #ifdef CONFIG_CMD_A ... stuff_spl_does_not_need(); #endif ... }
? Otherwise we would end up building files we don't use, but then all of the un-used code gets garbage collected.
- -- Tom