Re: [U-Boot] [PATCH 2/2] x86: fsp: Remove the call to set up internal uart in fsp_init()

On 1 June 2017 at 04:41, Bin Meng bmeng.cn@gmail.com wrote:

First of all, it's inappropriate to call setup_internal_uart() in a generic API fsp_init(), as CONFIG_INTERNAL_UART is an option that is only available on BayTrail platform. Secondly even for BayTrail, there is no need to call setup_internal_uart() at all, as Intel FSP will do this for us.

Signed-off-by: Bin Meng bmeng.cn@gmail.com

---

arch/x86/lib/fsp/fsp_support.c | 4 ---- 1 file changed, 4 deletions(-)

Reviewed-by: Simon Glass sjg@chromium.org