Re: [PATCH 08/20] dm: mdio: Use ofnode_phy_is_fixed_link() API

On Tue, Mar 2, 2021 at 5:35 PM Bin Meng bmeng.cn@gmail.com wrote:

Switch to use the ofnode_phy_is_fixed_link() API which can support both the new and old DT bindings.

Signed-off-by: Bin Meng bmeng.cn@gmail.com

net/mdio-uclass.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/mdio-uclass.c b/net/mdio-uclass.c index 5da984ca3f..2a9533c88b 100644 --- a/net/mdio-uclass.c +++ b/net/mdio-uclass.c @@ -11,6 +11,7 @@ #include <miiphy.h> #include <dm/device-internal.h> #include <dm/device_compat.h> +#include <dm/of_extra.h> #include <dm/uclass-internal.h> #include <linux/compat.h>

@@ -140,7 +141,7 @@ static struct phy_device *dm_eth_connect_phy_handle(struct udevice *ethdev, int i;

    if (CONFIG_IS_ENABLED(PHY_FIXED) &&

•       ofnode_valid(dev_read_subnode(ethdev, "fixed-link"))) {
  

•       ofnode_phy_is_fixed_link(dev_ofnode(ethdev), NULL)) {
            phy = phy_connect(NULL, -1, ethdev, interface);
            goto out;
    }
  

-- 2.25.1

Reviewed-By: Ramon Fried rfried.dev@gmail.com