Hi Andreas,
On Mon, 05 Nov 2012 09:31:55 +0100, "Andreas Bießmann" andreas.devel@googlemail.com wrote:
Dear Albert Aribaud,
DDR means DRAM in general?
Yes -- but DRAM is no better, as it still describes a technology (class). I'm going tu use "system RAM" to describe it.
- must use GD to store any data which must be passed on to later,
-----------------------------------------------------------------------^
Fixed.
- stages, including the reloction destination and the new stack
- pointer address, below which the stack resides and above it the
------------------------^ Full stop? The rest of the sentence makes no sense to me.
Rewritten.
+#if defined(CONFIG_NAND_SPL)
- /* deprecated, use instead CONFIG_SPL_BUILD */
I wonder if we can emit a #warning here
Hmm... Will test and let people know how many boards stop compiling cleanly.
+#ifdef CONFIG_SPL_BUILD
I think this should be negated. The coloured LED stuff was enabled for non SPL builds before!
Correct.
- bl coloured_LED_init
- bl red_led_on
+#endif
- /* call board_init_r(gd_t *id, ulong dest_addr) */
Shouldn't this move down in the #elif path?
Moved.
Best regards
Andreas Bießmann
Thanks a lot for your review!
Amicalement,