8 Apr
2020
8 Apr
'20
7:03 p.m.
On Tue, Apr 07, 2020 at 08:57:25PM -0600, Simon Glass wrote:
On Fri, 3 Apr 2020 at 06:53, Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
On Mon, Mar 30, 2020 at 05:12:52PM -0600, Simon Glass wrote:
This header relates to ACPI and we are about to add some more ACPI headers. Move this one into a new directory so they are together.
FWIW, Reviewed-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
One nit below.
-#ifdef CONFIG_X86
There is nothing in commit message about this change. Is it safe? Don't you get new compiler warnings (like defined-but-not-used)?
Not that I can see. Since it isn't specific to x86 anymore it seems like a good idea to remove this #ifdef
Please mention in commit message.
--
With Best Regards,
Andy Shevchenko