Re: [U-Boot] [PATCH v3 1/3] usb:ehci-mx6 add board_usb_phy_mode function

On Monday, November 10, 2014 at 02:01:50 AM, Peng Fan wrote: [...]

...

...

in usb_phy_mode, query a PHY for it's mode.

And righter after usb_phy_enable in ehci-mx6.c.

•   type = usb_phy_enable(index, ehci) ? USB_INIT_DEVICE :
  

USB_INIT_HOST;

•   usb_phy_enable(index, ehci);
  

•   type = usb_phy_mode(index);
  
  

usb_phy_enable return 0 but not return val & USBPHY_CTRL_OTG_ID. There is no status bit for query enabled or not, so just return 0.

In board file: int board_usb_phy_mode(int port) {

      if (port == 1)

              return USB_INIT_HOST;

      else

              return usb_phy_mode(port);

}

I think this is better way then previous patch, but i did not find where to put the usb_phy_mode prototype type, since board file will use it.

Looks OK otherwise.

Sent out v4 patch, please review.

Thanks! Will do as time permits. Sorry for possible delays.

Best regards, Marek Vasut