Dear Łukasz Dałek,
On 27.09.2012 02:07, Marek Vasut wrote:
Dear Łukasz Dałek,
On 27.09.2012 01:58, Marek Vasut wrote:
Dear Łukasz Dałek,
On 27.09.2012 01:32, Marek Vasut wrote:
Dear Łukasz Dałek,
> On 26.09.2012 18:13, Marek Vasut wrote: >> Dear Łukasz Dałek, >> >>> On 26.09.2012 17:29, Marek Vasut wrote: >>>> Dear Lukasz Dalek, >>>> >>>>> Basic support of HP iPAQ h2200 palmtop. Support includes also >>>>> USB ethernet gadget. >>>> >>>> Two minor nits ... can you extend the patch description? >>>> >>>>> Signed-off-by: Lukasz Dalekluk0104@gmail.com >>>>> [...] >>>>> +h2200 arm pxa >>>>> +h2200_usbeth arm pxa h2200 >>>>> >>>>> - >>>> >>>> Can you not enable USB ethernet by default? >>>> >>>> [...] >>> >>> I don't understand. >>> >>> make h2200_config creates config without usb ethernet >>> make h2200_usbeth_config creates config with usb ethernet >> >> Why not just make config with usb ethernet then? > > Sorry but I don't understand. You've asked me that can I not > enable USB ethernet by default.
I think you misunderstood. I was never against enabling the USB ethernet. I was against enabling it before the USB ethernet code is in, so it won't break bisectability.
If I did really say so, I'm sorry for the confusion.
So you want from me to split h2200 patches? I mean to prepare 2 patches: 1st one only adding support for device and 2nd one adding support for ethernet?
Oh, that would work nicely, good idea.
Ok, I will prepare them. But not sooner than tommorow.
Take your time ... PXA won't run anywhere anyway. btw. you're polish? I might actually find you some old PXA device.
Yes, I'm polish. I've one: pxa25x.
I have a pile of PXA boards here ... I think you can make do with the pxa255 for now and I'll see if I can find something for you.
Łukasz Dałek
Best regards, Marek Vasut