Hi Simon,
On Wed, 23 Apr 2014 09:04:20 -0600 Simon Glass sjg@chromium.org wrote:
Hi Masahiro,
On 21 April 2014 19:00, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
Hi Simon,
On Mon, 21 Apr 2014 15:02:20 -0600 Simon Glass sjg@chromium.org wrote:
Hi Masahiro,
On 21 April 2014 03:39, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
Prior to commit 33a02da0, all boards must have board/${BOARD}/ or board/${VENDOR}/${BOARD}/ directory. Now this rule is obsolete.
It looks weird that sandbox defines "vendor" and "board" just for meeting the old U-Boot directory structure.
Signed-off-by: Masahiro Yamada yamada.m@jp.panasonic.com Cc: Simon Glass sjg@chromium.org
Simon,
I moved board/sandbox/sandbox/sandbox.c to arch/sandbox/lib/sandbox.c
But if there is a more suitable place or file-name, please move.
I like the README move, but I worry about not having a sandbox board, from the point of view of discoverability. How will people find it?
I am not sure if this is necessary.
I just personaly thought the board directory seems odd for Sandbox because it is not a real board.
If you don't like this patch, feel free to reject it.
I think it is better to have board/sandbox. Is it possible to have a null vendor, so we don't need board/sandbox/sandbox?
Of cource. There are many boards without vendors.
In that case, you can set the 5th column to '-' in boards.cfg.
Active sandbox sandbox - sandbox sandbox sandbox
to
Active sandbox sandbox - - sandbox sandbox
With this change, you can decrease one level hierarchy.
board/sandbox/sandbox/sandbox.c -> board/sandbox/sandbox.c
Best Regards Masahiro Yamada