Re: [U-Boot] [PATCH] driver/fsl_pci: Added fsl_pci_init_port function to initialize a single PCIe port.

Dear Poonam Aggrwal,

In message 1250775038-20372-1-git-send-email-poonam.aggrwal@freescale.com you wrote:

• Added a generic function fsl_pci_init_port in drivers/pci/fsl_pci.c to initialize a PCIe port.
• fsl_pci_init_port can be called from board specific pcie initialization routine, per-port.
• This will reduce the code redundancy in the most of the Freescale board specific PCIe inits.

Signed-off-by: Poonam Aggrwal poonam.aggrwal@freescale.com Signed-off-by: Kumar Gala galak@kernel.crashing.org

---

NAK.

I see just dead code added, without any users.

If this gets used somewhere, this should be visible in the patch, and lead to code removed somewhere?

Best regards,

Wolfgang Denk