Wolfgang,
The syscalls table allocation _IS_ Necessary to make the devices code, especially the console to work. In console.c : console_setfile() looks up the proper function pointers by using the syscalls table, console_init_r needs it also. You know the table is all of 11 longs. Rewriting the code to work differently would likely take up more space then using the table....And syscalls will show up.
As far as the VFD goes. I have no problem undoing the move. I am nearly positive that its move would have any effect. My rational was it should be in the devices init, so putting it close was the next best thing to doing it correctly.
Regards,
Richard W.
-----Original Message----- From: Wolfgang Denk [mailto:wd@denx.de] Sent: Thursday, June 19, 2003 5:39 PM To: Woodruff, Richard Cc: u-boot-users@lists.sourceforge.net Subject: Re: [PATCH] Enable device and console for ARM (II).
In message FD2AC9A020DDD51194710008C7089B20053D4C81@dlee17.itg.ti.com you wrote:
Here is an updated patch against u-boot.0.3.0 with console_init_f defined. I added the call into what appears to be the proper place, into the init_sequence[], just like the PPC code does.
Sorry, but I reject this patch for the same reasons I just rejected the earlier version of this patch.
Again: the code is OK, and I want to include it, but you do a few things (VFD, syscalls) which you should leave as is.
Please resubmit.
Best regards,
Wolfgang Denk
-- Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-4596-87 Fax: (+49)-8142-4596-88 Email: wd@denx.de Every little picofarad has a nanohenry all its own. - Don Vonada