On Thu, Sep 8, 2011 at 9:41 PM, Joel A Fernandes agnel.joel@gmail.com wrote:
On Thu, Sep 8, 2011 at 10:10 AM, Kridner, Jason jdk@ti.com wrote:
On Sep 8, 2011, at 11:03 AM, "Albert ARIBAUD" albert.u.boot@aribaud.net wrote:
Hi Joel,
Le 08/09/2011 16:56, Joel A Fernandes a écrit :
Also, I agree with Albert: there should be no need for a separate userbutton command.
Please fix and resubmit.
If this patch is to be dropped, then I'm not sure why the need to resubmit?
I gather the "resubmit" means "resubmit the patch set minus this patch and renumbered accordingly".
One thing that would be necessary is to replace the default bootcmd with one that uses the gpio command and to enable the gpio command.
Actually the functions in arch/arm/cpu/armv7/omap-common/gpio.c are not compatible with the ones used by common/cmd_led.c
The patches from Sanjeev Premi seemed to me to handle the deltas. Are you applying those? They are working for me for use with the led command.
What would be the right place to implement the required functions for the gpio command?
- In the (beagle)board file as wrappers to the omap gpio functions
- In the gpio.c file in omap-common
- Any other option?
Do you mean to replace userbutton? As long as the gpio command returns a status, then you should be able to remove userbutton from the board.c file and add usage of gpio to replace userbutton in the omap3_beagle.h config header file. (Of course, the patches should apply those changes in opposite order to make sure git bisect doesn't show breakage.)
If you are saying that gpio.c is missing functionality, please describe the missing functionality.
Thanks, Joel _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot