Hi Tom,
On Wed, 8 Jan 2025 at 11:25, Tom Rini trini@konsulko.com wrote:
On Mon, Jan 06, 2025 at 07:32:13AM -0700, Simon Glass wrote:
This function uses separate arguments for data and size. Use the new abuf instead, so that they are paired and in one place. In some cases it also saves an argument, thus potentially reducing code size.
This is one of the commits that globally increases size in both full U-Boot and SPL/etc.
Is all of the "abuf" changes just a "tidy up" that increases the code a bit?
Yes, a tidy-up which I hope will help overall. I have been thinking for a while of how to avoid having addr/size and ptr/size passed everywhere. For now abuf seems to provide some sort of solution.
I see this:
18: boot: Update fit_image_get_emb_data to use abuf aarch64: (for 1/1 boards) all +4.0 bss -24.0 spl/u-boot-spl:all +16.0 spl/u-boot-spl:text +16.0 text +28.0
so growth on firefly-rk3399 but not with rk3288. I am not sure if the growth will tail off as there are more users, though. We might even be able to be more clever with static inlines.
Regards, Simon