On Sun, Nov 19, 2023 at 11:23:41AM -0700, Simon Glass wrote:
Hi Tom,
On Sun, 19 Nov 2023 at 08:59, Tom Rini trini@konsulko.com wrote:
On Sun, Nov 19, 2023 at 07:46:39AM -0700, Simon Glass wrote:
[snip]
diff --git a/include/cyclic.h b/include/cyclic.h index 44ad3cb6b803..d3b368dd90df 100644 --- a/include/cyclic.h +++ b/include/cyclic.h @@ -11,6 +11,7 @@ #ifndef __cyclic_h #define __cyclic_h
+#include <linux/kconfig.h> #include <linux/list.h> #include <asm/types.h>
Is this really needed? What's blowing up since we should have -include .../linux/kconfig.h cover this.
It is the CONFIG_IS_ENABLED() when building. We have kconfig.h in a few other places (used by tools) too.
In file included from include/watchdog.h:13, from tools/../lib/sha1.c:25, from tools/generated/lib/sha1.c:1: include/cyclic.h:47:22: error: missing binary operator before token "(" 47 | #if CONFIG_IS_ENABLED(CYCLIC) | ^
OK, for this we need to cleanup lib/sha*.c include directives. I'm tackling that now.