On Thu, Feb 15, 2018 at 03:33:29PM +0100, Lukasz Majewski wrote:
Hi Fabio,
This reverts commit d695d6627803dbb78a226e04b0436a01633a9936.
Commit d695d6627803 ("spl: eMMC/SD: Provide one __weak spl_boot_mode() function") breaks the boot on several i.MX6 boards, such as cuboxi and wandboard:
U-Boot SPL 2018.03-rc1-00212-g48914fc119 (Feb 10 2018 - 11:04:33 +1300) Trying to boot from MMC1 Failed to mount ext2 filesystem... spl_load_image_ext: ext4fs mount err - 0
Revert it so that we can boot U-Boot again.
This is IMHO throwing the baby with the batch....
I kind of feel we need to revert this too, sorry. I'm also worried that we've broken some of the other platforms that also have funky if-else expected logic, and we'll be at the point soon where we have enough platforms that need to override the spl_boot_mode func with what they had before that it's not a huge win.