5 Feb
2015
5 Feb
'15
4:04 a.m.
On 4 February 2015 at 05:05, Hans de Goede hdegoede@redhat.com wrote:
All callers of malloc should already do error checking, and may even be able to continue without the alloc succeeding.
Moreover, common/malloc_simple.c is the only user of .rodata.str1.1 in common/built-in.o when building the SPL, triggering this gcc bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54303
Causing .rodata to grow with e.g. 0xc21 bytes, nullifying all benefits of using malloc_simple in the first place.
Signed-off-by: Hans de Goede hdegoede@redhat.com
common/malloc_simple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Great find, thanks!
Acked-by: Simon Glass sjg@chromium.org