14 Mar
2021
14 Mar
'21
9:32 p.m.
Hi Tom,
On Sun, 14 Mar 2021 at 12:33, Tom Rini trini@konsulko.com wrote:
On Wed, Jan 20, 2021 at 08:10:57PM -0700, Simon Glass wrote:
At present if logging not enabled, log_info() becomes a nop. But we want log output at the 'info' level to be akin to printf(). Update the macro to pass the output straight to printf() in this case.
This mimics the behaviour for the log_...() macros like log_debug() and log_info(), so we can drop the special case for these.
Add new tests to cover this case. Signed-off-by: Simon Glass sjg@chromium.org
Changes in v2:
- Update commit message and cover letter to mention log_...() macros
- Add a test for !CONFIG_LOG
- Update log() to (effectively) call debug() for log_level == LOGL_DEBUG
As is, this last patch in the series causes tests to fail on sandbox. I'm re-testing 1-5 by themselves right now.
OK thanks, great to see this. I'll revisit once things land.
Regrads, Simon