Marek, In common/usb_kbd.c, you applied code to wrong place. You should apply my change to function usb_kbd_testc(), instead of usb_kbd_getc(). Could you help to correct it?
Thanks, Jim
-----Original Message----- From: Marek Vasut [mailto:marex@denx.de] Sent: Wednesday, August 21, 2013 12:27 PM To: Jim Lin Cc: joe.hershberger@gmail.com; u-boot@lists.denx.de; Tom Warren; swarren@wwwdotorg.org Subject: Re: [PATCH v9 2/2] console: usb: kbd: To improve TFTP booting performance
Dear Jim Lin,
TFTP booting is slow when a USB keyboard is installed and stdin has usbkbd added. This fix is to change Ctrl-C polling for USB keyboard to every second when NET transfer is running.
Signed-off-by: Jim Lin jilin@nvidia.com
Changes in v2:
- Change configuration name from CONFIG_CTRLC_POLL_MS to
CONFIG_CTRLC_POLL_S. 2. New code will be executed only when CONFIG_CTRLC_POLL_S is defined in configuration header file. 3. Add description in README.console. Changes in v3:
- Move changes to common/usb_kbd.c and doc/README.usb 2. Rename
config setting to CONFIG_USBKB_TESTC_PERIOD. 3. Remove slow response on USB-keyboard input when TFTP boot is not running. Changes in v4:
- Remove changes in doc/README.usb, common/usb_kbd.c and CONFIG_USBKB_TESTC_PERIOD
- Modify net/net.c
Changes in v5:
- Change variable name to ctrlc_t_start.
- Use two calls of get_timer(0) to get time gap.
Changes in v6:
- In common/usb_kbd.c, check net_busy_flag to determine whether we poll USB keyboard status.
- In include/usb.h, add external variable declaration net_busy_flag
Changes in v7:
- In common/usb_kbd.c and include/usb.h, add #ifdef CONFIG_CMD_NET.
- In common/usb_kbd.c, modify code to get correct time gap.
Changes in v8:
- Add __maybe_unused for variable kbd_testc_tms.
Changes in v9:
- Move external variable declaration from include/usb.h to
common/usb_kbd.c
common/usb_kbd.c | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-)
Applied, thanks.
Best regards, Marek Vasut
-- nvpublic