On Saturday, August 28, 2010 21:59:26 Reinhard Meyer wrote:
On 29.08.2010 02:14, Mike Frysinger wrote:
if you want to take the patch i posted and extend that by itself with the comments here, and then do the ramtron patch separately on top of that, that'd be great.
Hehe, you like to impose extra work on poor moi....
i can do the pre-ramtron stuff if you like
the first patch would add the table method and a #define IDCODE_LEN 5 at the top of file
the ramtron patch would then add (inside the table) #ifdef CONFIG_SPI_FRAM_RAMTRON {6, 0xc2, spi_fram_probe_ramtron}, # if IDCODE_LEN<9 # undef IDCODE_LEN # define IDCODE_LEN 9 # endif #endif
Not exactly nice, but that way there is only one place where device specific stuff happens, and we will automatically get the largest idbuffer required for all the non-trivial devices included.
looks fine to me -mike