Re: [U-Boot] [U-BOOT][PATCH] mmc: remove the hard setting for tran_speed

Hi Andy.

On 05/08/2012 06:50 AM, Andy Fleming wrote:

On Mon, Apr 2, 2012 at 1:31 PM, Jae hoon Chung jh80.chung@gmail.com wrote:

...

...

           if (mmc->card_caps & MMC_MODE_HS) {
                   if (mmc->card_caps & MMC_MODE_HS_52MHz)

•                           mmc_set_clock(mmc, 52000000);
  

•                           mmc->tran_speed = 52000000;
                   else
  

•                           mmc_set_clock(mmc, 26000000);
  

•           } else
  

•                   mmc_set_clock(mmc, 20000000);
  

•                           mmc->tran_speed = 26000000;
  

•           }
  

Why did you remove the outer else clause, here (the one that set the speed to 20000000)?

If card->caps didn't set MMC_MODE_HS, then it's set to mmc->tran_speed. That value is assigned from freq * mult.

I think that is reasonable..if set to 20000000 here, then why need freq & mult?

Best Regards, Jaehoon Chung