Re: [U-Boot] [PATCH v3] fdt: rework fdt_fixup_ethernet() to use env instead of bd_t

Dear Kumar Gala,

In message Pine.LNX.4.64.0808190924520.6029@blarg.am.freescale.net you wrote:

--- a/common/fdt_support.c +++ b/common/fdt_support.c @@ -368,55 +368,96 @@ int fdt_fixup_memory(void *blob, u64 start, u64 size)

...

• /* walk the env looking for eth[.*]addr */
• for (i=0; env_get_char(i) != '\0'; i=nxt+1) {

• for (nxt=i; env_get_char(nxt) != '\0'; ++nxt)
  

• 	;
  

Please do not do this. env_get_char() is a function that is internal to the environment handling code. It is not supposed to be exported to arbitrary code. Please do not make any assumptions about the internals of how the environment is stored.

NAK.

Best regards,

Wolfgang Denk