
6 Nov
2015
6 Nov
'15
12:47 a.m.
Hi Marek,
On 2015年11月06日 00:16, Marek Vasut wrote:
On Thursday, November 05, 2015 at 09:42:43 AM, Thomas Chou wrote:
Do not allocate rx buf in net.c, because altera_tse allocates its own rx buf in driver. This can save 6KB memory.
Signed-off-by: Thomas Chou thomas@wytron.com.tw
Shouldn't we instead fix the altera driver to use the pre-allocated buffer ?
It should not. The drivers and devices are dynamically binding in driver model. The buffers used by devices should be allocated per device. Eg, there may be multiple ethernet devices and they should not use the same pre-allocated rx bufs.
Best regards, Thomas