2 Apr
2014
2 Apr
'14
11:18 p.m.
On Tue, Apr 01, 2014 at 05:26:40PM +0300, Roger Quadros wrote:
Commit 2faf5fb82ed6 introduced a regression that causes a data abort when running scsi init followed by scsi reset.
There are 2 problems with the original commit
- ALLOC_CACHE_ALIGN_BUFFER() allocates memory on the stack but is
assigned to ataid[port] and used by other functions. 2) The function ata_scsiop_inquiry() tries to free memory which was never allocated on the heap.
Fix these problems by using tmpid as a temporary cache aligned buffer. Allocate memory separately for ataid[port] and re-use it if required.
Fixes: 2faf5fb82ed6 (ahci: Fix cache align error messages)
Reported-by: Eli Nidam elini@marvell.com Signed-off-by: Roger Quadros rogerq@ti.com
Applied to u-boot/master, thanks!
--
Tom