Re: [PATCH v6] board: mntre: imx8mq: Add MNT Reform 2 board support

On 2023-01-19, Patrick Wildt wrote:

The MNT Reform 2 is a modular DIY laptop. In its initial version it is based on the BoundaryDevices i.MX8MQ SoM. Some parts have been lifted from BoundaryDevices official U-Boot downstream project.

Signed-off-by: Patrick Wildt patrick@blueri.se

Changes since v3:

• Adjusted to Binman changes in main branch.
• Cleaned up environment variables akin to i.MX8MM.
• Added vendor-prefix to device tree filename.
• Provided ramdisk_addr_r.

ramdisk_addr_r no longer appears to be set.

+++ b/include/configs/imx8mq_reform2.h

...

+#include <config_distro_bootcmd.h>

+/* Initial environment variables */ +#define CFG_EXTRA_ENV_SETTINGS \

• BOOTENV \
• "scriptaddr=" __stringify(CONFIG_SYS_LOAD_ADDR) "\0" \
• "kernel_addr_r=" __stringify(CONFIG_SYS_LOAD_ADDR) "\0" \

Maybe put "ramdisk_addr_r=0x44000000\0" here?

I had proposed 0x44000000 as a valid value before.

Other than that, seems to work well enough for me, thanks for working on this!

Would love to be CCed on future patch series. :)

live well, vagrant