10 Dec
2014
10 Dec
'14
7 p.m.
Hi Masahiro,
On 10 December 2014 at 06:19, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
Hi Simon,
Some minor comments.
On Fri, 5 Dec 2014 08:32:08 -0700 Simon Glass sjg@chromium.org wrote:
+int sandbox_i2c_probe_chip(struct udevice *bus, uint chip_addr, uint chip_flags) +{
static ??
Fixed.
/* Always let probe succeed */printf("%s: Detected probe\n", __func__);return 0;+}
+struct dm_i2c_ops sandbox_i2c_emul_ops = {
.xfer = sandbox_i2c_eeprom_xfer,.probe_chip = sandbox_i2c_probe_chip,+};
Are you using .probe_chip ? (Or planning to use it in the future?)
sandbox-i2c does not use a dedicated .probe_chip handler.
I'll drop it for now. As you say the xfer() function is suitable and returns the correct value for a probe_chip.
Regards, Simon