On Monday 04 November 2002 05:35 pm, Wolfgang Denk wrote:
Well, maybe. If you check the #ifdef-mess we have right now, you will find that
many #ifdef's come clustered for seral boards, and I don;t see much difference between
#if defined(CONFIG_CCM) || \ defined(CONFIG_COGENT) || \ defined(CONFIG_CPCI405) || \ defined(CONFIG_EVB64260) || \ defined(CONFIG_HYMOD) || \ defined(CONFIG_LWMON) || \ defined(CONFIG_PCU_E) || \ defined(CONFIG_W7O) || \ defined(CONFIG_MISC_INIT_R) /* miscellaneous platform dependent initialisations */ misc_init_r (); #endif
Yeh, This should really be replaced with #ifdef CONFIG_MISC_INIT_R
and I think most new ports use the common CONFIG_xxxx. Only some of the early boards use board specific defines for common config options.
and
if (machine_is_CCM() || \ machine_is_COGENT() || \ machine_is_CPCI405() || \ machine_is_EVB64260() || \ machine_is_HYMOD() || \ machine_is_LWMON() || \ machine_is_PCU_E() || \ machine_is_W7O() || \ machine_is_MISC_INIT_R() ) { /* miscellaneous platform dependent initialisations */ misc_init_r (); }
- Many of these #ifdef's are used to conditionammy define variables, or initializers, where an if() cannot be used, so we would have to support BOTH forms, which is actually worse.
Good point.
Thanks for all the hard work (to everyone, including the armboot folks). U-boot is a great project!
Kyle.