El Thu, Jan 21, 2010 at 01:10:45PM -0800 Ben Warren ha dit:
Matthias Kaehlcke wrote:
cs8900_initialize(): remove unecessary calls to free(), fix memory leak and report errors in the return value
Signed-off-by: Matthias Kaehlcke matthias@kaehlcke.net
drivers/net/cs8900.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/cs8900.c b/drivers/net/cs8900.c index df36004..7895048 100644 --- a/drivers/net/cs8900.c +++ b/drivers/net/cs8900.c @@ -308,15 +308,14 @@ int cs8900_initialize(u8 dev_num, int base_addr) dev = malloc(sizeof(*dev)); if (!dev) {
free(dev);return 0;
return -1;'return 0' is actually correct. It refers to the number of devices that were initialized.
ok, i was in doubt and had a look at another driver, which returns a negative value and followed the bad example :(
Removing the 'free' calls is good, though.
i'll send out a patch without the return value 'fix' then
best regards