On Monday, April 06, 2015 at 10:59:09 AM, nikhil.badola@freescale.com wrote:
-----Original Message----- From: Marek Vasut [mailto:marex@denx.de] Sent: Thursday, April 02, 2015 10:32 PM To: Badola Nikhil-B46172 Cc: u-boot@lists.denx.de Subject: Re: [PATCH] drivers:usb:fsl: Implement Erratum A-009116 for XHCI controller
On Friday, March 27, 2015 at 04:47:54 AM, Nikhil Badola wrote:
This adjusts (micro)frame length to appropriate value thus avoiding USB devices to time out over a longer run
Signed-off-by: Nikhil Badola nikhil.badola@freescale.com
Hi,
it seems the XHCI driver from Freescale was never applied, since no maintainer was ever in CC and there was no effort from the author to contact anyone after sending it out. That's rather unfortunate.
Freescale XHCI driver's author is already talking with HW teams to see if there's some PHY shutdown sequence available for FSL socs...hence the delay.
Hi, OK.
I briefly reviewed the driver which you linked and it seems like it is almost exact copy of the xhci-omap.c . We certainly don't want this level of code duplication.
I agree with the fact that code duplication should be minimized. However the driver for same controller would follow same initialization steps...until an effort is made in open-source by someone to write a single driver file with common initialization code, this code will keep getting duplicated.
I agree. I won't allow such explicitly duplicated code in, so it's up to you to do the deduplication. Thanks :)
Would it be possible for you to pick up that driver, work your change into it, avoid the code duplication and repost the whole thing please ?
Best regards, Marek Vasut
Best regards, Marek Vasut