Hello Albert,
Albert ARIBAUD wrote:
Le 26/08/2010 08:30, Heiko Schocher a écrit :
Beside of that, I have just some minor codstyling comments:
Meanwhile, I've run checkpatch on this file and fixed every warning and error, thus some of your comments were taken care of in the process. That left:
+#define MVTWSI_STATUS_DATA_R_NAK 0x58 /* our NAK, not the slave's */
line too long.
Checkpatch did not complain on this one. Is there a specific line length contraint beside passing checkpatch?
Yep, 78 characters.
+/*
- Wait for IFLG to raise, or return 'timeout'; then if status is as
expected,
- return 0 (ok) or return 'wrong status'.
- */
blank line not necessary.
Which blank line exactly? Between the comment block and code? If so,
Yes.
does this apply everywhere, i.e. after the topmost license comment block, before blocks of #define, etc?
No, there, it is Ok.
As a side note, if V2 gets Acked by Prafulla and you, can you add the commit to your i2c tree and ask for a new pull? Anyway, Wolfgang said he won't resume activity on u-boot before sep 5th.
Yes, if I and Prafulla accept it, this is the usual way.
bye, Heiko