On Tue, Jan 8, 2019 at 3:04 AM Bin Meng bmeng.cn@gmail.com wrote:
On Tue, Jan 8, 2019 at 2:38 AM Andy Shevchenko andy.shevchenko@gmail.com wrote:
On Mon, Jan 7, 2019 at 8:34 PM Andy Shevchenko andy.shevchenko@gmail.com wrote:
The platform does have DM_MMC and BLK as far as I can see, other than that I have no idea how CONFIG_DM_SCSI becomes set. Something broken upper, not on this certain board.
config X86 ... imply DM_SCSI ...
This has to be fixed, not my board. Message now is bogus.
No. SCSI is common for almost all x86 boards, hence we use 'imply'.
Which is good and not a problem per se.
And we acknowledge that some boards may not have it so we don't use 'select'. You can turn it off in your board defconfig.
No, the board shouldn't care about some architecture defaults and those defaults should be carefully chosen in the first place. Nevertheless, I like the Tom's patch which fixes the actual problem.