2 Oct
2009
2 Oct
'09
2:41 p.m.
Dear Stefan Roese,
In message 1254486916-3040-1-git-send-email-sr@denx.de you wrote:
This message is printed upon PCIe bus scan, not only upon error, but also if no PCIe device is detected at all. Since this is not an error, let's remove this message in this case. We already have the message "link is not up." if there is no PCIe device present.
Thanks.
Acked-by: Wolfgang Denk wd@denx.de
But looking at this patch, it seems that larger parts in this (supposedly) board-specific code are actually more or less identical.
Should we not factor out such common code?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Real programmers don't comment their code. It was hard to write, it
should be hard to understand.