Re: [PATCH v4] gpio: mxc_gpio: fix reading state of GPIO pins in output mode

On Wed, Aug 28, 2024 at 10:09 AM Tomas Paukrt tomaspaukrt@email.cz wrote:

The PSR register works correctly for GPIO pins in input mode, but always returns 0 for GPIO pins in output mode unless the SION bit is set.

The DR register should be used for GPIO pins in output mode to allow correct getting of previously set output value.

Please note that the Linux gpio-mxc driver and the NXP U-Boot mxc_gpio driver already use the DR register for all GPIO pins in output mode:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i... https://github.com/nxp-imx/uboot-imx/commit/4afc3f90943c6b117f79b66d2cd04e64...

Signed-off-by: Tomas Paukrt tomaspaukrt@email.cz

Applied, thanks.