Subject: Re: [PATCH] armv8: cache_v8: fix mmu_set_region_dcache_behaviour
On Mon, May 11, 2020 at 04:41:07PM +0800, Peng Fan wrote:
enum dcache_option already shift left 2 bits, PMD_ATTRINDX(option), will wrongly shift left the attr 4bits, which is wrong. And make the region user set not has expected attribute and might affect the splitted block region.
Reviewed-by: Ye Li ye.li@nxp.com Signed-off-by: Peng Fan peng.fan@nxp.com
Please note that I reworded the commit message a bit. In the interest of fixing the bug now:
Applied to u-boot/master.
But on reading the code and macros to understand things better for the commit message, I wonder why we don't just use options directly now in the code?
Seems directly using options would make it a bit simplier! I agree.
Thanks, Peng.
Thanks!
-- Tom