On Sat, 2019-05-25 at 22:15 +0200, Marek Vasut wrote:
On 5/25/19 6:49 PM, Ezequiel Garcia wrote:
i.MX6 platforms boot U-Boot second-stage from unformatted space, and should not need Ext filesystem support on SPL.
The commit was generated with:
git grep -l MX6 -- configs/ | xargs grep -l SPL_FS_EXT4 | xargs sed -i -e '/CONFIG_SPL_FS_EXT4=y/d'
This change has a dramatic impact on SPL size:
./scripts/bloat-o-meter old new add/remove: 0/59 grow/shrink: 0/3 up/down: 0/-8674 (-8674) [..] Total: Before=38320, After=29646, chg -22.64%
Cc: Otavio Salvador otavio@ossystems.com.br Cc: Fabio Estevam fabio.estevam@nxp.com Cc: Peng Fan peng.fan@nxp.com Cc: Marek Vasut marex@denx.de Cc: Stefano Babic sbabic@denx.de Cc: Stefan Roese sr@denx.de Cc: "Eric Bénard" eric@eukrea.com Cc: Breno Lima breno.lima@nxp.com Cc: Francesco Montefoschi francesco.montefoschi@udoo.org Signed-off-by: Ezequiel Garcia ezequiel@collabora.com
Tested on Wandboard only. Maintainers, please ACK or NAK!
configs/cgtqmx6eval_defconfig | 1 - configs/mx6cuboxi_defconfig | 1 - configs/mx6sabreauto_defconfig | 1 - configs/mx6sabresd_defconfig | 1 - configs/mx6slevk_spl_defconfig | 1 - configs/mx6sxsabresd_spl_defconfig | 1 - configs/mx6ul_14x14_evk_defconfig | 1 - configs/mx6ul_9x9_evk_defconfig | 1 - configs/novena_defconfig | 1 -
NAK, I boot my Novena from ext4 and this just broke it.
And also, NAK, this removes functionality from SPL which worked fine before.
I'll drop from Novena, but I think the patch still makes some sense, why do you want Ext4 on SPL?
Thanks for the review, Eze