Hi Tom,
On Wed, Feb 19, 2014 at 09:19:04AM +0100, Lukasz Majewski wrote:
Hi Albert, Tom
Hi Lukasz,
On Wed, 12 Feb 2014 21:45:41 +0100, Lukasz Majewski l.majewski@majess.pl wrote:
I think, that the patch for fixing the unaligned access in this function has already been posted by Piotr Wilczek. We have experienced similar issues with Samsung's Exynos4 based targets.
[PATCH V2] disk:efi: avoid unaligned access on efi partition
Despite its disappearance from patchwork it shall be available at mailing list archive.
The v1 can be found at the following link: http://patchwork.ozlabs.org/patch/282753/
Neither V1 nor V2 have disappeared from patchwork. A "filter" on the subject, selecting "any" state and "both" archived and non-archived patches will return both:
V1: http://patchwork.ozlabs.org/patch/282753/ (New) V2: http://patchwork.ozlabs.org/patch/314717/ (Deferred)
(I think that the patchwork web interface does not make it possible at all to remove a patch anyway)
Thanks for pointing out. Now it is perfectly visible :-)
I've also un-deferred, for now, the patch as well.
Inclusion of v2 has been postponed since there was a discussion if we shall allow unaligned access (-mno-unaligned-access flag) at armv7 (after patches posted by Tom).
As fair as I can tell, we will keep the current approach so, I think that Tom will be willing to pull this patch (v2) now.
Agreed, but then we should make sure no one has comments on V2 that they might have withheld due to the initial rejection of V2.
Any comments?
This patch do fix unaligned access problem on Trats2 (Exynos4412), when we restore/create GPT, so I would like to know if there are any new inquires regarding this patch.
Can you give me some steps on how to hit this bug? I believe it's a bug and I believe we need to fix it, I just want to investigate a few things while we've got a trigger case right now. Thanks!
The easiest way is to type:
gpt write mmc 0 $partitions
before that you shall define several uuid's.
For reference please look into the Trats2/Trats code and ./doc/README.gpt
As a side note - I'm using following toolchain: CROSS_COMPILE=/opt/eldk-5.4/armv7a/sysroots/i686-eldk-linux/usr/bin/armv7a-vfp-neon-linux-gnueabi/arm-linux-gnueabi-
It is 4.7.2 from denx.de.