Re: [U-Boot] [PATCH v2] add new board nas62x0

Dear Luka Perkov,

In message 20120317234054.GA21334@w500.lan you wrote:

Add support for new boards RaidSonic ICY BOX NAS6210 and NAS6220 boards.

Just a tiny detail...

...

+/*

• • Version number information
• */

+#ifdef CONFIG_BOARD_IS_IB_NAS6210 +# define CONFIG_IDENT_STRING " RaidSonic ICY BOX IB-NAS6210" +#elif CONFIG_BOARD_IS_IB_NAS6220

For robustness, this should rather be

#elif defined(CONFIG_BOARD_IS_IB_NAS6220)

[and for consistency, you then may want to reqrite the #if above as

#if defined(CONFIG_BOARD_IS_IB_NAS6210)

]

Thanks!

Best regards,

Wolfgang Denk