Dear "Reinhard Meyer (-VC)",
In message 4C08EC47.5070603@emk-elektronik.de you wrote:
This Patch adds support for the EMK TOP7000 CPU Module Part 1: new files
Signed-off-by: Reinhard Meyer reinhard.meyer@emk-elektronik.de
But please clean up the code berfore resubmitting...
--- /dev/null +++ b/board/emk/top7000/top7000.c
...
+static const struct sdram_config sdram_config = {
- .data_bits = SDRAM_DATA_16BIT,
- .row_bits = 13,
- .col_bits = 9,
- .bank_bits = 2,
- .cas = 3,
Indentation by TAB only - please fix globally.
+#ifdef CONFIG_CMD_I2C
- // first select SCL and SDA gpio
No C++ comments - please fix globally.
- portmux_select_gpio(PORTMUX_PORT_A,(1<<SDA_PIN),
No trailing white space - please fix globally
- portmux_select_gpio(PORTMUX_PORT_A,(1<<SDA_PIN),
PORTMUX_DIR_OUTPUT|PORTMUX_INIT_LOW|PORTMUX_OPEN_DRAIN);
Long lines wrapped by mailer. Please fix your mailer setup (or rather use "git send-email" for sending patches.
Note: line too long - please fix globally.
- if (expected_size != actual_size)
printf("Warning: Only %lu of %lu MiB SDRAM is working\n",actual_size >> 20, expected_size >> 20);
Curly braces needed for multiline statements - please fix globally.
+int misc_init_r (void)
------------------^
+{
- /* read 'factory' part of EEPROM */
- extern void read_factory_r (void);
- read_factory_r ();
---------------------^
No spaces after function names - please fix globally.
...
--- /dev/null +++ b/board/emk/top7000/u-boot.lds @@ -0,0 +1,72 @@ +/* -*- Fundamental -*-
Incorrect multiline comment style - please fix globally.
Best regards,
Wolfgang Denk