Re: [U-Boot] [PATCH 2/3] add serial driver for pollux CPU

Dear Brian Cavagnolo,

In message 1275417750-10020-2-git-send-email-brian@cozybit.com you wrote:

Signed-off-by: Brian Cavagnolo brian@cozybit.com Signed-off-by: Andrey Yurovsky yurovsky@gmail.com

---

drivers/serial/Makefile | 1 + drivers/serial/serial_pollux.c | 116 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 117 insertions(+), 0 deletions(-) create mode 100644 drivers/serial/serial_pollux.c

Please see previous comments about using C structs with I/O accessors, coding style etc.

General question: do we really need a new UART driver, or can this be generalized with other drivers?

Best regards,

Wolfgang Denk