On Fri, Feb 26, 2021 at 1:45 PM Uwe Kleine-König uwe@kleine-koenig.org wrote:
Hi Dennis,
thanks for your feedback.
On 2/26/21 12:23 AM, Dennis Gilmore wrote:
Thanks for submitting, I have been meaning to do so myself, I have been meaning to go through and try get the dts files in a decent shape. I think that most of what is in arch/arm/dts/rk3399-kobol-helios64-u-boot.dtsi belongs in arch/arm/dts/rk3399-kobol-helios64.dts
I understood that the intention of the separation into two files is that the one should track the Linux dts. Is that wrong?
No, that's correct, but it should also likely then be submitted for upstream Linux inclusion.
I also wonder if we shouldn't default to building an image for use in the SPI flash since the system has it available.
I didn't test that but expected that I can write the resulting image to the spi flash and it works just fine. If you want something else here I need some direction about what to change.
Best regards Uwe