Hi Ben,
On Sun, 8 Oct 2023 at 15:55, Ben Wolsieffer benwolsieffer@gmail.com wrote:
Hi Simon,
On Sat, Oct 07, 2023 at 02:18:48PM -0600, Simon Glass wrote:
Hi Ben,
On Sat, 7 Oct 2023 at 09:55, Ben Wolsieffer benwolsieffer@gmail.com
wrote:
Using the unqualified "mmc" boot target causes the Raspberry Pi 4 to fail to boot. c771e5b explains this approach as follows:
We don't need to specify the mmc devices individually, since they
are
used in order from 0 to 2, and standard boot uses that order anyway.
In practice, U-Boot first attempts to boot from the unconnected mmc1 interface, and, when this fails, moves on to attempt the USB and
network
boot targets rather than trying mmc0.
This patch explicitly enumerates the mmc interfaces, causing each to
be
attempted in turn. This matches what is done on other boards, and
allows
the system to boot successfully.
Fixes: c771e5b8c2 ("arm: rpi: Switch to standard boot") Signed-off-by: Ben Wolsieffer benwolsieffer@gmail.com
board/raspberrypi/rpi/rpi.env | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Does this patch help? [1]. Alternatively, if you just remove that variable entirely, does it do the right thing?
Yes, trying either of those suggestions makes it work correctly.
Thank you for testing this
In that case, I would rather that [1] since it should fix it for all boards. If you want to send a patch to drop boot_targets, please do and I'll leave that to Peter.
Regards, Simon
[1]
https://patchwork.ozlabs.org/project/uboot/patch/20230923205017.1754340-1-sj...
Thanks, Ben
Regards, Simon