Hi Sylvain,
On 06.08.2015 21:01, LEMIEUX, SYLVAIN wrote:
Hi Vladimir,
See comment below.
-----Original Message----- From: Vladimir Zapolskiy [mailto:vz@mleia.com]
Hi Sylvain,
On 05.08.2015 21:31, slemieux.tyco@gmail.com wrote:
From: Sylvain Lemieux slemieux@tycoint.com
Incorporate USB driver from legacy LPCLinux NXP BSP. The files taken from the legacy patch are:
- lpc32xx USB driver
- lpc3250 header file USB registers definition.
The legacy driver was updated and clean-up as part of the integration with the latest u-boot.
Signed-off-by: Sylvain Lemieux slemieux@tycoint.com
[...]
diff --git a/arch/arm/cpu/arm926ejs/lpc32xx/devices.c b/arch/arm/cpu/arm926ejs/lpc32xx/devices.c index 0d2ef7a..3da0952 100644 --- a/arch/arm/cpu/arm926ejs/lpc32xx/devices.c +++ b/arch/arm/cpu/arm926ejs/lpc32xx/devices.c @@ -82,6 +82,12 @@ void lpc32xx_i2c_init(unsigned int devnum) writel(ctrl, &clk->i2cclk_ctrl); }
+void lpc32xx_usb_init(void) +{
- /* Do not route the UART 5 Tx/Rx pins to the USB D+ and USB D- pins. */
- clrbits_le32(&ctrl->ctrl, UART_CTRL_UART5_USB_MODE);
+}
Please replace clrbits_le32() with writel(), the same motivation as shown for DMA driver.
It is not possible to do it for this instance; the control register is affecting multiple UARTs; refer to UM10326 LPC32x0 User manual Rev. 3, table 459 for details.
accepted, please ignore this review comment.
With best wishes, Vladimir