19 Jul
2011
19 Jul
'11
7:36 p.m.
-----Original Message----- From: Ajay Bhargav [mailto:ajay.bhargav@einfochips.com] Sent: Tuesday, July 19, 2011 9:53 AM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik Subject: Re: [PATCH 1/4] gpio: Adds GPIO driver support for Armada100
----- "Prafulla Wadaskar" prafulla@marvell.com wrote:
You should define all GPIO register in a single struct And point them with base address offsets
I suggest you to add mvgpio.c instead of armada100_gpio.c This will be used in future by other Marvell SoCs.
GPIO registers might vary for other Marvell SoCs? How to deal with that?
That can be thought of while adding support for othe SoCs. Preferably define register struct in asm/arch/gpio.h
Regards.. Prafulla . .