Hi Christian,
ansuelsmth@gmail.com wrote on Sat, 21 Sep 2024 00:50:00 +0200:
Implement support for LED activity. If the feature is enabled, make the defined ACTIVITY LED to signal mtd write or erase operations.
I'm curious, why did you not consider reads in your proposal? I think in general as long as you use a device the LED should blink. While you're performing a read you cannot do anything else with the chip so I would definitely consider the read path as well.
Also, I would expect the blinking to continue when the device is accessed, no matter who is asking for it. So for instance when I load my kernel into RAM, I believe it should blink. Hence, why not considering the mtd layer rather than the command .c file?
Signed-off-by: Christian Marangi ansuelsmth@gmail.com
cmd/mtd.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
diff --git a/cmd/mtd.c b/cmd/mtd.c index 795aaa2b37d..dae90b0e6e4 100644 --- a/cmd/mtd.c +++ b/cmd/mtd.c
Thanks, Miquèl