
Dear Heiko Schocher,
In message 4B7D06DC.8020107@denx.de you wrote: ...
create mode 100644 include/configs/km_arm.h create mode 100644 include/configs/suen3.h
It would be good if you can merge these two files since single board board support For additional board that you are planning, you can even add separate file or think of splitting it. For better readability and to avoid complexity, I recommend to have one single file per board in include/config
Hmm.. I think we tend to collect common config options in one file, so board config files are not so big. Ok, actual it is only one arm board from keymile here, but there come more, and so it is sensible to collect common options for this group of boards immediately ...
ACK. I agree to do this split right from the beginning if it is clear that more such boards will be added soon.
+u32 kwmpp_config[] = {
- MPP0_NF_IO2,
- MPP1_NF_IO3,
- MPP2_NF_IO4,
- MPP3_NF_IO5,
- MPP4_NF_IO6,
- MPP5_NF_IO7,
- MPP6_SYSRST_OUTn,
- MPP7_PEX_RST_OUTn,
+#if defined(CONFIG_SOFT_I2C)
- MPP8_GPIO, /* SDA */
- MPP9_GPIO, /* SCL */
+#else
you can remove else part and ifdef with CONFIG_HARD_I2C
But if this is in code, the user can fast switch to HARD_I2C, if he wants it ... Ok, I delete it.
I understood that Prafulla NOT suggested delete the code, but to change the
#else into #endif #ifdef CONFIG_HARD_I2C
...
Please remove below stuff, this is risky and not needed
see comment for this from Stefan:
http://lists.denx.de/pipermail/u-boot/2010-February/067410.html
I got no comment from you, so I lthought it is Ok!
What should I do?
Keep it. It really doen't hurt. This whole MACH_TYPE stuff is broken by design anyway. So adding such workarounds are just collateral damages and can be ignored for now. Eventually we can get rid of this when we switch to using device trees.
Best regards,
Wolfgang Denk