+Tom
On 05.12.2018, at 03:25, Kever Yang kever.yang@rock-chips.com wrote:
The U-Boot eMMC does not need to care about the power for Rockchip SoC, because if the board is using eMMC, the power will default on (for bootrom), and we do not do power management for it like kernel, so the 'vmmc', 'vqmmc' is only useful for SD in U-Boot.
This make U-Boot can boot into kernel even if the pmic driver is broken.
If the PMIC driver is broken, we should fix the PMIC driver. I would feel more comfortable w/o this statement.
The rk3288-evb dts may be used in many boards using rockchip reference schematic but with little change, so we hope it can be more robust to boot into next stage.
Again, this is not how the DTS should be used. I believe that Heiko, Fabio and I had already highlighted this in comments to the earlier thread.
I am willing to move ahead with these and simply merge them, if either Tom or Simon agree that they are fine with a DTS that describes one board and is then used for incompatible (if they were compatible, this change wasn’t needed) boards...
Signed-off-by: Kever Yang kever.yang@rock-chips.com
Reviewed-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com
Changes in v2:
- only update for rk3288-evb, remove change for other boards.
arch/arm/dts/rk3288-evb.dtsi | 2 -- 1 file changed, 2 deletions(-)
diff --git a/arch/arm/dts/rk3288-evb.dtsi b/arch/arm/dts/rk3288-evb.dtsi index ce75bd5d28..04902c0bd3 100644 --- a/arch/arm/dts/rk3288-evb.dtsi +++ b/arch/arm/dts/rk3288-evb.dtsi @@ -150,8 +150,6 @@ num-slots = <1>; pinctrl-names = "default"; pinctrl-0 = <&emmc_clk>, <&emmc_cmd>, <&emmc_pwr>, <&emmc_bus8>;
- vmmc-supply = <&vcc_io>;
- vqmmc-supply = <&vcc_flash>; status = "okay";
};
-- 2.18.0